WIP: Vendor the SQLite amalgamation instead of the autoconf tarball #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
across all our platforms
flavorjones
force-pushed
the
flavorjones-dep-sqlite-use-amalgamation
branch
from
686de87 to
8751b27
Compare
|
Blurgh, need to do some work around feature detection in order to keep the capability to link against a system library; using |
flavorjones
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - this PR exists to get feedback on builds across all supported platforms.
Context
Since v3.48.0, SQLite's "autoconf" release does not actually use autoconf, and as a result there have been small related breakages including:
Database#load_extensionsis not enabled on Windows when using native gems or compiling vendored source code (sqlite 3.48.0+) #618I suspect that moving to the amalgamation and explicitly setting compiler and linker flags from within the extconf.rb might be more reliable.